add pre-view page before uploading capture #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafu
reviewed
Jul 12, 2022
| } | ||
|
|
||
| private removeCurrentCapture() { | ||
| // TODO: remove file this.curCaptureFilePath to free space |
Contributor
There was a problem hiding this comment.
@sultanmyrza Can we remove the unconfirmed file in this PR, or can you share some details of the difficulty, and we can open a following-up task for it?
Contributor
Author
There was a problem hiding this comment.
@bafu, when user take photos or videos it's kept in file system so we need to clean up files. I don't think it's hard by I will add another pull req that will implement this feature (today)
Contributor
Author
|
Here is the result for "fix(pre-publish.page): add header, footer to match UX" https://imgur.com/a/84zBQPM (iOS and Android) |
bafu
approved these changes
Jul 13, 2022
Contributor
There was a problem hiding this comment.
Accept this PR with 3 known issues
- The positions of the back and confirm buttons, and the header beight are not ideal on my phone. Considering that the phone resolution is not general, I will accept this PR first.
- No black footer behind the camera button.
- Unconfirmed temporary photos will not be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito